Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration tests #3470

Merged
merged 34 commits into from
Sep 7, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 6, 2024

  • Now that curl uses --retry-all-errors we can remove the explicit sleeps

  • Remove the serverId file as part of example/integration test cleanup to try and force a shutdown if the mill shutdown call doesn't work for some reason

    • I tried making the ./mill shutdown command after each integration test either required to succeed or removing it.
      • Making it required to succeed does not work because if the Mill build.mill fails to compile the shutdown task is not available and it fails, and we have a lot of integration tests that fail to compile since that's what they're testing
      • Removing it could work, but better to try our best to clean up the integration test subprocesses so others can run without interference
  • Make ./mill shutdown return exit code 0 correctly, rather than letting it leak the exit code of the previously run command

  • Mill server avoids logging anything when out/ folder is missing, to avoid re-creating the out-folder and potentially racing with whoever deleted it

Added some unit and integration tests to exercise the various codepaths

@lihaoyi lihaoyi changed the title Integration test cleanup 2 Integration test cleanup mandatory shutdown Sep 6, 2024
@lihaoyi lihaoyi changed the title Integration test cleanup mandatory shutdown Clean up integration tests Sep 7, 2024
@lihaoyi lihaoyi marked this pull request as ready for review September 7, 2024 03:27
@lihaoyi lihaoyi merged commit 8cfa7e2 into com-lihaoyi:main Sep 7, 2024
25 checks passed
@lefou lefou added this to the 0.12.0-RC1 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants