-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up integration tests #3470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
Integration test cleanup 2
Integration test cleanup mandatory shutdown
Sep 6, 2024
lihaoyi
changed the title
Integration test cleanup mandatory shutdown
Clean up integration tests
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
curl
uses--retry-all-errors
we can remove the explicitsleep
sRemove the
serverId
file as part of example/integration test cleanup to try and force a shutdown if themill shutdown
call doesn't work for some reason./mill shutdown
command after each integration test either required to succeed or removing it.build.mill
fails to compile theshutdown
task is not available and it fails, and we have a lot of integration tests that fail to compile since that's what they're testingMake
./mill shutdown
return exit code0
correctly, rather than letting it leak the exit code of the previously run commandMill server avoids logging anything when
out/
folder is missing, to avoid re-creating the out-folder and potentially racing with whoever deleted itAdded some unit and integration tests to exercise the various codepaths