Move .mill.sc extension to .mill.scala
#3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Sep 12, 2024
| for (line <- os.read.lines(buildFile.get)) { | ||
| val rootBuildFileNames = Seq("build.sc", "build.mill", "build.mill.scala") | ||
| val buildFile = rootBuildFileNames.map(testRepoRoot / _) | ||
| .find(os.exists) |
There was a problem hiding this comment.
I think we should report multiple detected root files. If we have a strong precedence, just reporting a warning should be enough. E.g. to allow for sym-linking build.mill to build.mill.scala without build failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.scalahas a lot better support for things likepackagedeclarations that.scdoes not, and so will serve as a better alternative to.milluntil IDE support for the new extension catches up