Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer repositoriesTask to hard-coded repositories in scalapblib #3529

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Prefer repositoriesTask to hard-coded repositories in scalapblib #3529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions contrib/scalapblib/src/mill/contrib/scalapblib/ScalaPBModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package mill
package contrib.scalapblib

import coursier.MavenRepository
import coursier.core.Version
import mill.api.{IO, Loose, PathRef}
import mill.scalalib.Lib.resolveDependencies
Expand Down Expand Up @@ -75,10 +74,7 @@ trait ScalaPBModule extends ScalaModule {

def scalaPBClasspath: T[Loose.Agg[PathRef]] = T {
resolveDependencies(
Seq(
coursier.LocalRepositories.ivy2Local,
MavenRepository("https://repo1.maven.org/maven2")
),
repositoriesTask(),
Seq(ivy"com.thesamet.scalapb::scalapbc:${scalaPBVersion()}")
.map(Lib.depToBoundDep(_, "2.13.1"))
)
Expand Down
Loading