Revert zinc to 1.9.6 to fix incremental compilation in the build #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3748. Workaround for sbt/zinc#1461 (comment) that disables incremental compilation in multi-file builds
With this PR, whitespace changes to
build.millrecompile 1 build file in about 5 seconds, whereas without this PR they would recompile 20 build file taking 10 seconds. Presumably the difference would be larger on larger projectsUpdates a number of tests to verify that incremental compilation in build files works correctly
Needed to downgrade Mill's own Scala version to 2.13.13 for compatibility concerns, but this doesn't affect projects built using Mill which can continue to use any Scala version. We may need to find some fix before upgrading to Scala 3.
Not terribly happy with the downgrade. Going to just leave this open for now since it's not a blocker for anything, and we may receive a fix from upstream which would allow us to tighten up the tests while negate the need for this downgrade