Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out anonymous classes during test discovery #3911

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 5, 2024

Mitigates #3910 by hackily filtering out all anonymous classes, but non-anonymous non-test classes still cause the problem

Added a unit test to check this specific misbehavior

@lefou
Copy link
Member

lefou commented Nov 5, 2024

Since we're more or less just reusing the JupiterFramework, we should first check upstream, whether these spurious discovered test classes are incidentally or not. TBH, I have no idea of the complete feature set of Junit5.

Is there already an upstream issue we can link to?

@lefou
Copy link
Member

lefou commented Nov 5, 2024

It would be nice to also update to the latest version of jupiter-interface. Maybe this is already fixed upstream?

@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 5, 2024

@lefou oh thsts a good point, should take another look at that pr

@lihaoyi lihaoyi marked this pull request as ready for review November 5, 2024 08:43
@lihaoyi lihaoyi merged commit 68269b8 into com-lihaoyi:main Nov 5, 2024
24 checks passed
@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 5, 2024

merging this first just as a mitigation. The upstream sbt-jupiter integrstion does do some special stuff beyond just being a test framework, so likely we need to see what its doing and replicate that logic in Mill

@lefou lefou added this to the 0.12.2 milestone Nov 5, 2024
@lefou
Copy link
Member

lefou commented Nov 5, 2024

I'm going to cut a snapshot release, as I have a project where we have lots of these spurious zero-ran test runs. This is also a nice test for the new publish pipeline (#3904).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants