Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prompt update hash check #3933

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 10, 2024

The logic was incorrect: we still need to re-calculate the prompt even if the statuses don't change, because the wall clock time changes and so the second tickers need to be updated

@lihaoyi lihaoyi marked this pull request as ready for review November 10, 2024 11:56
@lihaoyi lihaoyi merged commit 0d798d4 into com-lihaoyi:main Nov 10, 2024
24 of 25 checks passed
@lefou lefou added this to the 0.12.2 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants