Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonlib: improved dependency management and examples #3998

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

jodersky
Copy link
Member

@jodersky jodersky commented Nov 20, 2024

Make the dependency management more flexible:

  • allow users to re-use requirements.txt files (inspired by the same pants feature)
  • separate library and tool requirements
    • library deps are transitive, and will in the future be included as requirements in distributions
    • tool requirements are not transitive and won't be included in distributions. They're used for things like type checkers and bundlers (which can all be extracted into separated traits later on if we want to).
  • support referencing wheel files directly
  • allow user-defined PYTHONPATH
  • custom package repos
  • lockfile support Removing this from this pull request, since it's likely a bit more complex than I initially thought. Pants delegates this behavior to PEX, but we should see if this can be done with more basic tools, or we decide to rely on pex for everything.
  • examples for all the above

Part of #3928

@himanshumahajan138
Copy link
Contributor

@jodersky Sir I have done the Basic example and if you want/allow i can help in writing examples for this also...

@jodersky
Copy link
Member Author

thanks, however I already started working on the examples

@jodersky jodersky force-pushed the jo/python-deps branch 2 times, most recently from b2628a6 to b8255ac Compare November 26, 2024 08:30
@jodersky jodersky marked this pull request as ready for review November 26, 2024 08:50
@jodersky jodersky requested a review from lihaoyi November 26, 2024 08:50
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jodersky jodersky merged commit 41e21e0 into com-lihaoyi:main Nov 27, 2024
27 checks passed
@lefou lefou added this to the 0.12.4 milestone Nov 27, 2024
@jodersky jodersky added the pythonlib Issues related to Mill's python support label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pythonlib Issues related to Mill's python support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants