-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonlib: improved dependency management and examples #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jodersky Sir I have done the Basic example and if you want/allow i can help in writing examples for this also... |
thanks, however I already started working on the examples |
4 tasks
jodersky
force-pushed
the
jo/python-deps
branch
2 times, most recently
from
November 26, 2024 08:30
b2628a6
to
b8255ac
Compare
lihaoyi
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
lihaoyi
reviewed
Nov 26, 2024
lihaoyi
reviewed
Nov 26, 2024
example/pythonlib/dependencies/4-downloading-unmanaged-wheels/build.mill
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Nov 26, 2024
example/pythonlib/dependencies/4-downloading-unmanaged-wheels/build.mill
Outdated
Show resolved
Hide resolved
lihaoyi
reviewed
Nov 26, 2024
lihaoyi
reviewed
Nov 26, 2024
lihaoyi
reviewed
Nov 26, 2024
jodersky
force-pushed
the
jo/python-deps
branch
from
November 27, 2024 15:21
b8255ac
to
c05f252
Compare
jodersky
force-pushed
the
jo/python-deps
branch
from
November 27, 2024 15:48
66d20a2
to
4338fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the dependency management more flexible:
requirements.txt
files (inspired by the same pants feature)lockfile supportRemoving this from this pull request, since it's likely a bit more complex than I initially thought. Pants delegates this behavior to PEX, but we should see if this can be done with more basic tools, or we decide to rely on pex for everything.Part of #3928