Integrate lefou/millw and millw.bat into Mill repository, fix GenIdea on windows
#4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
millw and millw.bat into Mill repositorymillw and millw.bat into Mill repository, fix GenIdea on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2161, fixes #3203, parts of #4050
For now I just merged the two files unchanged except for tweaking the comment to refer to the
Original Project page. We can continue to evolve the scripts post-merge. We already had a copy inci/mill.batthat I removed, and changed the github actions to point at the top-level version, and integrated the newmill.batinto the doc-site download instructions and example zipsThe changes to the
mill/mill.batscripts should be covered by the existing integration and bootstrap testsThis is enough to make Mill's own codebase importable to IntelliJ on Windows