Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve handling of windows multiline prompt #4053

Merged
merged 20 commits into from
Dec 1, 2024
Merged

improve handling of windows multiline prompt #4053

merged 20 commits into from
Dec 1, 2024
+272 −281

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 30, 2024 •
edited
Loading

This generally tries to avoid clearing and re-rendering parts of the UI unnecessarily, which which reduce flicker in slower terminals like Windows

@lihaoyi lihaoyi changed the title [WIP] improve handling of windows multiline prompt improve handling of windows multiline prompt Dec 1, 2024
@lihaoyi lihaoyi merged commit e793d31 into com-lihaoyi:main Dec 1, 2024
3 checks passed
@lefou lefou added this to the 0.12.4 milestone Dec 1, 2024
@lihaoyi lihaoyi mentioned this pull request Dec 2, 2024
Merged
lihaoyi added a commit that referenced this pull request Dec 2, 2024
@lihaoyi
Re-enable harcdoded prompt sizing for windows (#4059)
41cc33f 
Was meant to land in #4053 but
got lost in the merge

This hardcoding is just a hack until
#4055 is resolved
@lihaoyi lihaoyi mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou