Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow exception stack trace in mill.api.Exception #4069

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

alexarchambault
Copy link
Contributor

This keeps the original exception as cause of mill.api.Exception, so that its message, stack traces, and those of its causes, are usually printed when a mill.api.Exception gets thrown

This keeps the original exception as cause of mill.api.Exception, so
that its message, stack traces, and those of its causes, are usually
printed when a mill.api.Exception gets thrown
@alexarchambault
Copy link
Contributor Author

See this gist for a before / after of an exception in unit tests. The latter has the original exception, so is easier to debug.

@lihaoyi lihaoyi merged commit c07efca into com-lihaoyi:main Dec 4, 2024
27 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Dec 4, 2024

Thanks!

@lefou lefou added this to the 0.12.4 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants