Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More improvements for prompt logger #4080

Merged
merged 5 commits into from
Dec 6, 2024
Merged

More improvements for prompt logger #4080

merged 5 commits into from
Dec 6, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Dec 6, 2024 •
edited
Loading

  • Skip the two blank spaces at the left side of the header, since it looks weird on terminates with a line cursor rather than a block cursor (e.g. on Windows Terminal)
  • Remove the === footer in non-interactive mode, since usually the end of the prompt is clear enough from context and it can be very verbose

@lihaoyi lihaoyi merged commit b525595 into com-lihaoyi:main Dec 6, 2024
27 checks passed
@lefou lefou added this to the 0.12.4 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou