Fix Prompt Logger #4134
Merged
Fix Prompt Logger #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4133
The problem was that the cleanup-process-folder logic running in
ServerLauncher#runwas taking place after theterminfofile was initially created inrunTermInfoThread, resulting in it wiping out theterminfofile that then never gets re-created until you resize the terminal.This PR moves the cleanup logic to always run just before the
terminfofile is created, renamingrunTermInfoThreadintoprepareMillRunFolderand making it responsible for both cleanup of the mill process folder as well as initialization with newterminfometadata