Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure files are readable when traversing source files. #423

Merged
merged 1 commit into from
Sep 5, 2018

Commits on Sep 1, 2018

  1. Make sure files are readable when traversing source files.

    Mill was trying to read all files found under the source directory to
    create a digest for each of them. This was causing an error for broken
    symlinks.
    
    At first I believed temporary files should be ignored to avoid this problem,
    and asked at the gitter channel how to go about this, but overriding the `sources`
    task as [suggested](https://gitter.im/lihaoyi/mill?at=5ad6cd801130fe3d36eb7655)
    by @lihaoyi didn't actually help.
    
    on a simple scala project, editing a file with Emacs, creates a link file, like:
    
    ```
    vic@oeiuwq ~/h/foo> ls -la foo/src/
    total 8
    drwxr-xr-x  4 vic  staff  128 Sep  1 12:23 .
    lrwxr-xr-x  1 vic  staff   22 Sep  1 12:23 .#hello.scala -> vic@oeiuwq.local.10748
    drwxr-xr-x  3 vic  staff   96 Sep  1 12:22 ..
    -rw-r--r--  1 vic  staff   12 Sep  1 12:22 hello.scala
    ```
    
    So this patch only makes sures that the files (or the symlink here) is actually
    readable before trying to digest it.
    
    Fixes com-lihaoyi#402
    vic committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    e25c61a View commit details
    Browse the repository at this point in the history