Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] zip file handling (500USD Bounty) #161

Closed
bertlebee opened this issue Mar 29, 2023 · 5 comments
Closed

[feature request] zip file handling (500USD Bounty) #161

bertlebee opened this issue Mar 29, 2023 · 5 comments
Labels
bounty help wanted Extra attention is needed
Milestone

Comments

@bertlebee
Copy link

bertlebee commented Mar 29, 2023


From the maintainer Li Haoyi: I'm putting a 500USD bounty on this issue, payable by bank transfer on a merged PR implementing this.

Success criteria is a design and implementation of zip file handling in OS-Lib: zipping, unzipping, listing-without-unzipping, usage as a filesystem so you can generate os.Paths to read and write inside the zip without unzipping, etc. Along with tests exercising the logic, updated documentation, and documented limitations (e.g. not all filesystem operations can take place inside a zip file). This is to be done in the OS-Lib style, with default parameters, nested objects with apply methods as necessary, and exception-based error handling.


I'm loving all the filesystem handling stuff, particularly walking the file system, but it all falls down when I hit a zip file (actually a jar in this case, but whatevs). The only remotely friendly way I've found to deal with zip files in scala is better-files. At the moment I've just pulled in the dep for handling the jars, but it'd be awesome to have support for zip files baked into os-lib, particularly the ability to walk into jars and copy files to jars as easily as os-lib makes these operations on regular files/folders.

@lefou lefou added the help wanted Extra attention is needed label Mar 29, 2023
@lihaoyi
Copy link
Member

lihaoyi commented Sep 8, 2024

I've also come across this need

@lihaoyi lihaoyi changed the title [feature request] zip file handling [feature request] zip file handling (500USD Bounty) Sep 15, 2024
wb14123 added a commit to wb14123/os-lib that referenced this issue Sep 17, 2024
Resolves com-lihaoyi#161. Add Zip
support.

`os.zip(path)` to read/write zip file. File will be created if not
exists.

`zipFile / subPath` to get a path. Should be able to support all the
file operations like copy, move, delete and so on.
@lefou lefou added the bounty label Sep 19, 2024
@chaitanyawaikar
Copy link
Contributor

@lefou Do we have a discord channel where we can discuss the approach ?

@lihaoyi
Copy link
Member

lihaoyi commented Sep 22, 2024

@chaitanyawaikar can use the com-lihaoyi discord https://discord.com/channels/632150470000902164/940067748103487558

@chaitanyawaikar
Copy link
Contributor

lihaoyi

Could you please send an invite link please ? The above link does not lead me to any channel

@chaitanyawaikar
Copy link
Contributor

Hello @lihaoyi
I am raising the following PR to address this issue. I look forward to receiving your valuable feedback.

@lihaoyi lihaoyi closed this as completed Oct 7, 2024
@lefou lefou added this to the after 0.10.7 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants