Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra!: adhere to monorepo strucutre of open-scd #289

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

juancho0202
Copy link

Closes #282

Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
@juancho0202 juancho0202 requested a review from Stef3st November 2, 2023 09:10
@juancho0202 juancho0202 self-assigned this Nov 2, 2023
Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
Copy link

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Id suggest to move the document folder and add a Apache-2.0 license on repository level

Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
Stef3st
Stef3st previously approved these changes Nov 2, 2023
Copy link

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Attempting to save public/cim/README.md while ignoring cim xml files

Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
@juancho0202 juancho0202 merged commit 0703eaa into main Nov 2, 2023
6 checks passed
@juancho0202 juancho0202 deleted the 282-adhere-to-monorepository-structure branch November 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make CoMPAS-OpenSCD adhere to the monorepository structure
2 participants