forked from openscd/open-scd
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync CoMPAS-OpenSCD with OpenSCD #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enscd#1288) feat(editors/ied): Improve IED editor UI for IED and LN selection, closes openscd#1287 --------- Co-authored-by: Tamás Russ <tamas.russ@tuta.io>
splitted into 2 workflows as a workaround to account for prs from forks
…ugin, so it can be reused (openscd#1337)
* Chore: Renamed Logging to Historing * Fixed tests * Fixed german translation * Update packages/open-scd/src/Historing.ts Co-authored-by: Juan Munoz <juan.munoz@alliander.com> --------- Co-authored-by: Juan Munoz <juan.munoz@alliander.com>
* feat: ability to see `Services` section's XML Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> * chore: update outdated services snapshot test file Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> * test: added integration test Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> * chore: fix type error in services.ts Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> --------- Signed-off-by: Juan Muñoz <juan.munoz@alliander.com>
* Feat: Added ISD file extensions * Feat: Added ISD File extensions
* fix: supervision updates after ied rename Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com> * chore: improve efficiency and tidy up Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com> --------- Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
juancho0202
suggested changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include changes to /packages/compas-open-scd/
with the following files:
- Plugging.ts
- Historing.ts
- Hosting.ts
- open-scd.ts
- editors/IED.ts
- wizards/service-log-settingsgroup.ts
- wizards/service-networking.ts
- wizards/service-sampled-values.ts
- wizards/service-GSEControl.ts
- wizards/service-report-configurations.ts
- wizards/service-clientServer-configurations.ts
- wizards/services.ts
- wizards/foundation/references.ts
- translations/de.ts
- translations/en.ts
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
Signed-off-by: Stef3st <steffen.van.den.driest@alliander.com>
juancho0202
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #283, #292