Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port changes to changelog and UPGRADING.md for release v0.38.0 #1341

Merged
merged 2 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.

This file was deleted.

1 change: 0 additions & 1 deletion .changelog/unreleased/bug-fixes/890-mempool-fix-cache.md

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- `[node/state]` Add Go API to bootstrap block store and state store to a height. Make sure block sync starts syncing from bootstrapped height.
- `[node/state]` Add Go API to bootstrap block store and state store to a height. Make sure block sync starts syncing from bootstrapped height.
([\#1057](https://github.com/tendermint/tendermint/pull/#1057)) (@yihuang)
- `[state/store]` Added Go functions to save height at which offline state sync is performed.
([\#1057](https://github.com/tendermint/tendermint/pull/#1057)) (@jmalicevic)
- `[state/store]` Added Go functions to save height at which offline state sync is performed.
([\#1057](https://github.com/tendermint/tendermint/pull/#1057)) (@jmalicevic)
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[state]` Signature of `ExtendVote` changed in `BlockExecutor`.
It now includes the block whose precommit will be extended, an the state object.
([\#1270](https://github.com/cometbft/cometbft/pull/1270))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[config]` Remove `Version` field from `MempoolConfig`.
([\#260](https://github.com/cometbft/cometbft/issues/260))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[protobuf]` Remove fields `sender`, `priority`, and `mempool_error` from
`ResponseCheckTx`. ([\#260](https://github.com/cometbft/cometbft/issues/260))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[mempool]` Remove priority mempool.
([\#260](https://github.com/cometbft/cometbft/issues/260))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[state]` Move pruneBlocks from node/state to state/execution.
([\#6541](https://github.com/tendermint/tendermint/pull/6541))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[rpc]` Removed `begin_block_events` and `end_block_events` from `BlockResultsResponse`.
The events are merged into one field called `finalize_block_events`.
([\#9427](https://github.com/tendermint/tendermint/issues/9427))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[state/kvindexer]` Remove the function type from the event key stored in the database. This should be breaking only
for people who forked CometBFT and interact directly with the indexers kvstore.
([\#774](https://github.com/cometbft/cometbft/pull/774))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[kvindexer]` Added support for big integers and big floats in the kvindexer.
Breaking changes: function `Number` in package `libs/pubsub/query/syntax` changed its return value.
([\#797](https://github.com/cometbft/cometbft/pull/797))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[pubsub]` Added support for big integers and big floats in the pubsub event query system.
Breaking changes: function `Number` in package `libs/pubsub/query/syntax` changed its return value.
([\#797](https://github.com/cometbft/cometbft/pull/797))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[abci]` Move `app_hash` parameter from `Commit` to `FinalizeBlock`
([\#8664](https://github.com/tendermint/tendermint/pull/8664))
3 changes: 3 additions & 0 deletions .changelog/v0.38.0/breaking-changes/9468-finalize-block.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[abci]` Introduce `FinalizeBlock` which condenses `BeginBlock`, `DeliverTx`
and `EndBlock` into a single method call
([\#9468](https://github.com/tendermint/tendermint/pull/9468))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[p2p]` Remove unused p2p/trust package
([\#9625](https://github.com/tendermint/tendermint/pull/9625))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[inspect]` Add a new `inspect` command for introspecting
the state and block store of a crashed tendermint node.
([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[node]` Move DBContext and DBProvider from the node package to the config
package. ([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[rpc]` Remove global environment and replace with constructor
([\#9655](https://github.com/tendermint/tendermint/pull/9655))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `[metrics]` Move state-syncing and block-syncing metrics to
their respective packages. Move labels from block_syncing
-> blocksync_syncing and state_syncing -> statesync_syncing
([\#9682](https://github.com/tendermint/tendermint/pull/9682))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[kvindexer]` Forward porting the fixes done to the kvindexer in 0.37 in PR \#77
([\#423](https://github.com/cometbft/cometbft/pull/423))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[consensus]` Unexpected error conditions in `ApplyBlock` are non-recoverable, so ignoring the error and carrying on is a bug. We replaced a `return` that disregarded the error by a `panic`.
([\#496](https://github.com/cometbft/cometbft/pull/496))
2 changes: 2 additions & 0 deletions .changelog/v0.38.0/bug-fixes/524-rename-peerstate-tojson.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[consensus]` Rename `(*PeerState).ToJSON` to `MarshalJSON` to fix a logging data race
([\#524](https://github.com/cometbft/cometbft/pull/524))
6 changes: 6 additions & 0 deletions .changelog/v0.38.0/bug-fixes/575-fix-light-client-panic.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- `[light]` Fixed an edge case where a light client would panic when attempting
to query a node that (1) has started from a non-zero height and (2) does
not yet have any data. The light client will now, correctly, not panic
_and_ keep the node in its list of providers in the same way it would if
it queried a node starting from height zero that does not yet have data
([\#575](https://github.com/cometbft/cometbft/issues/575))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[abci]` Restore the snake_case naming in JSON serialization of
`ExecTxResult` ([\#855](https://github.com/cometbft/cometbft/issues/855)).
2 changes: 2 additions & 0 deletions .changelog/v0.38.0/bug-fixes/890-mempool-fix-cache.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[mempool/clist_mempool]` Prevent a transaction to appear twice in the mempool
([\#890](https://github.com/cometbft/cometbft/pull/890): @otrack)
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[docker]` Ensure Docker image uses consistent version of Go.
([\#9462](https://github.com/tendermint/tendermint/pull/9462))
2 changes: 2 additions & 0 deletions .changelog/v0.38.0/bug-fixes/9717-abci-cli-fix-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[abci-cli]` Fix broken abci-cli help command.
([\#9717](https://github.com/tendermint/tendermint/pull/9717))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `[rpc/grpc]` Mark the gRPC broadcast API as deprecated.
It will be superseded by a broader API as part of
[\#81](https://github.com/cometbft/cometbft/issues/81)
([\#650](https://github.com/cometbft/cometbft/issues/650))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- `[proxy]` Introduce `NewUnsyncLocalClientCreator`, which allows local ABCI
clients to have the same concurrency model as remote clients (i.e. one
mutex per client "connection", for each of the four ABCI "connections").
([\#9830](https://github.com/tendermint/tendermint/pull/9830))
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- `[abci]` New ABCI methods `VerifyVoteExtension` and `ExtendVote` allow validators to validate the vote extension data attached to a pre-commit message and allow applications to let their validators do more than just validate within consensus ([\#9836](https://github.com/tendermint/tendermint/pull/9836))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[blocksync]` Generate new metrics during BlockSync
([\#543](https://github.com/cometbft/cometbft/pull/543))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[crypto/merkle]` Improve HashAlternatives performance
([\#6443](https://github.com/tendermint/tendermint/pull/6443))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[p2p/pex]` Improve addrBook.hash performance
([\#6509](https://github.com/tendermint/tendermint/pull/6509))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[crypto/merkle]` Improve HashAlternatives performance
([\#6513](https://github.com/tendermint/tendermint/pull/6513))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[rpc]` Remove response data from response failure logs in order
to prevent large quantities of log data from being produced
([\#654](https://github.com/cometbft/cometbft/issues/654))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `[pubsub]` Performance improvements for the event query API
([\#7319](https://github.com/tendermint/tendermint/pull/7319))
3 changes: 3 additions & 0 deletions .changelog/v0.38.0/improvements/797-pubsub-float.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[pubsub/kvindexer]` Numeric query conditions and event values are represented as big floats with default precision of 125.
Integers are read as "big ints" and represented with as many bits as they need when converting to floats.
([\#797](https://github.com/cometbft/cometbft/pull/797))
13 changes: 13 additions & 0 deletions .changelog/v0.38.0/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
*September 12, 2023*

This release includes the second part of ABCI++, called ABCI 2.0.
ABCI 2.0 introduces ABCI methods `ExtendVote` and `VerifyVoteExtension`.
These new methods allow the application to add data (opaque to CometBFT),
called _vote extensions_ to precommit votes sent by validators.
These vote extensions are made available to the proposer(s) of the next height.
Additionally, ABCI 2.0 coalesces `BeginBlock`, `DeliverTx`, and `EndBlock`
into one method, `FinalizeBlock`, whose `Request*` and `Response*`
data structures contain the sum of all data previously contained
in the respective `Request*` and `Response*` data structures in
`BeginBlock`, `DeliverTx`, and `EndBlock`.
See the [specification](./spec/abci/) for more details on ABCI 2.0.
Loading
Loading