-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ImageCrop
to Image Crop
#5424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodes menu has inconsistency in names, some with spaces between words, other not.
huchenlei
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image Crop
you are changing is the node unique id, which is not supposed to be modified. You should do
NODE_DISPLAY_NAME_MAPPINGS = {
"ImageCrop": "Image Crop"
}
instead to modify display name.
NODE_DISPLAY_NAME_MAPPINGS = {
"ImageCrop": "Image Crop" that´s right! |
Include the node mapping name line for Image Crop Node
huchenlei
approved these changes
Oct 31, 2024
huchenlei
added
the
Good PR
This PR looks good to go, it needs comfy's final review.
label
Oct 31, 2024
@comfyanonymous PTAL. This is a straightforward change. |
huchenlei
changed the title
Node menu items, inconsistency in naming convention
Rename Oct 31, 2024
ImageCrop
to Image Crop
tiangles
pushed a commit
to diffus-me/ComfyUI
that referenced
this pull request
Nov 29, 2024
* Update nodes_images.py Nodes menu has inconsistency in names, some with spaces between words, other not. * Update nodes.py Include the node mapping name line for Image Crop Node * Update nodes_images.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback
Nodes menu has inconsistency in names, some with spaces between words, other not. i made some minor changes on our local installations (students project). This is something important for the next releases. The actual menu push developers to add their category into the top level, what is not the best option for the users to search for a specific category, if the category exists into various levels.
also, it must be considered that developers would have a guided structure to include their custom nodes packages into existing categories (until the node requires a new one) for consistency and easy search.
Mockup
By re-arranging the main node menu, we give to developers a way to inlude their custom nodes in a practical manner.
Pull request & future development
this first pull is about the Image Crop node, to give an overview on my next requests. if accepted, i will work make a complete proposal for this menu. i want to contribute to this project as a developer, mainly because my students are giving me a lot of user feedbacks and i believe it can serve the purpose of the community.
if you want to check my profil: https://www.linkedin.com/in/urieldeveaud/
thank you