Optimize model library #5841
Merged
Optimize model library #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Nov 29, 2024
| @@ -221,20 +222,6 @@ async def get_root(request): | |||
| def get_embeddings(self): | |||
| embeddings = folder_paths.get_filename_list("embeddings") | |||
| return web.json_response(list(map(lambda a: os.path.splitext(a)[0], embeddings))) | |||
|
|
|||
| @routes.get("/models") | |||
There was a problem hiding this comment.
We need to keep these routes for now if we want to merge this PR first. If we decide to land this PR after frontend changes has landed, the frontend side needs to be able to handle both APIs.
There was a problem hiding this comment.
These two APIs have not been removed, just moved to model_filemanager/model_filemanager.py. I can restore it if needed.
There was a problem hiding this comment.
The new API adds the prefix of /experiment. My plan is to retain the original API and then migrate it to the original API after the new function is stable.
robinjhuang
added
the
Good PR
huchenlei
requested changes
Dec 5, 2024
Ok |
comfyanonymous
requested review from
yoland68,
robinjhuang,
pythongosssss and
ltdrdata
as code owners
3.8 compatibility
huchenlei
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust model list responses to prepare optimized model library.
Add model preview interface.