Reland union type #5900

webfiltered · 2024-12-04T05:47:35Z

Relands Add union link connection type support #5806
Resolves Support wildcard type "*" in ComfyUI core #5890
Resolves comment in issue Support wildcard type "*" in ComfyUI core #5890 (comment)
Now uses almost(*) identical logic to former behaviour if types match:
- If types matched before this PR, they will still match
- If they do not match:
  - Check both types are string
  - Perform new union type check

(*) Only changes are one function call and a not not conversion

huchenlei

LGTM. Thanks for tracing this down!

tests-unit/execution_test/validate_node_input_test.py

webfiltered added 2 commits December 4, 2024 16:32

Reapply "Add union link connection type support (comfyanonymous#5806)" (

c3588f0

comfyanonymous#5889) This reverts commit bf9a90a.

Fix union type breaks existing type workarounds

3dca9a0

webfiltered mentioned this pull request Dec 4, 2024

Reland "Add union link connection type support" #5891

Closed

webfiltered added 2 commits December 4, 2024 17:12

Add non-string test

41c2dfb

Add tests for hacks and non-string types

ad43d4c

huchenlei approved these changes Dec 4, 2024

View reviewed changes

huchenlei reviewed Dec 4, 2024

View reviewed changes

tests-unit/execution_test/validate_node_input_test.py Outdated Show resolved Hide resolved

Support python versions lower than 3.11

9af17fd

webfiltered marked this pull request as ready for review December 4, 2024 16:26

webfiltered requested a review from comfyanonymous as a code owner December 4, 2024 16:26

comfyanonymous merged commit 4e402b1 into comfyanonymous:master Dec 4, 2024
5 checks passed

webfiltered deleted the reland-union-type branch December 4, 2024 20:20

Provide feedback