Lint unused import #5973
Merged
Lint unused import #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Dec 9, 2024
| @@ -87,7 +87,8 @@ def execute_script(script_path): | |||
|
|
|||
| if args.windows_standalone_build: | |||
| try: | |||
| import fix_torch | |||
| from fix_torch import fix_pytorch_libomp | |||
There was a problem hiding this comment.
Convert module level execution to a function call here to avoid the unused import.
huchenlei
requested review from
yoland68,
robinjhuang,
pythongosssss,
ltdrdata,
Kosinkadink and
comfyanonymous
as code owners
comfyanonymous
added
the
Run-CI-Test
|
(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=5973%2Fmerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces lint rule
unused-import.The fix is generated by
ruff --select F401 --fix **/*.pycommand. We should probably replace pylint with ruff later as it offers more features, and also faster (Written with Rust).