-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Newick tree support #3695
base: main
Are you sure you want to change the base?
Add Newick tree support #3695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acks-late-micro-short
really doesn't have much memory available, so don't be surprised when we get memory errors from that validation.
Would you agree that for a first implementation, it is OK? They should be around the same size as the multiple annotation JSON types. I'll be looking at re-routing file-to-object task to larger workers when implementing BIOM. |
Yes totally fine, was just a heads up. |
Summary of updates: The mime-types were not being really used as MIME-types but rather as input to Uppy. At the same time the need to support Since we don't need to actually map to mime types I've refactored things to a Newick validator now also handles time-out errors, memory errors. It also no longer exposes generic exceptions. |
Part of the pitch:
This PR adds support for Newick files.
.newick
suffix in the relative path.*.nwk
, used by the test files in the parser library.*.tree
, defined by Wikipedia.*.newick
, provided in the example files.At this point, it runs on
acks-late-micro-short
. As the Newick are not very hard to parse or very big.