Add CLSAG module for signature creation and verification #14
Conversation
| msg: &[u8; 32], | ||
| signing_key: Scalar, | ||
| signing_key_index: usize, | ||
| H_p_pk: EdwardsPoint, | ||
| alpha: Scalar, | ||
| ring: &[EdwardsPoint; RING_SIZE], | ||
| commitment_ring: &[EdwardsPoint; RING_SIZE], | ||
| fake_responses: [Scalar; RING_SIZE - 1], | ||
| z: Scalar, | ||
| pseudo_output_commitment: EdwardsPoint, | ||
| L: EdwardsPoint, | ||
| R: EdwardsPoint, | ||
| I: EdwardsPoint, |
There was a problem hiding this comment.
It really is a lot of arguments, Clippy! It would be good to document exactly what each of these arguments is, especially if this is to be a public API.
There was a problem hiding this comment.
Agreed. Recorded a ticket here: #25
| @@ -27,6 +27,7 @@ strict_encoding_support = ["strict_encoding"] | |||
| hex = "0.4.3" | |||
| hex-literal = "0.3.1" | |||
| keccak-hash = "0.7.0" | |||
There was a problem hiding this comment.
I'm not against adding tiny-keccak but you could just use keccak-hash like we did for bulletproof. keccak-hash uses tiny-keccak under the hood anyway, so the dependency footprint would actually be the same. I don't know.
There was a problem hiding this comment.
Yeah, I am thinking of throwing out keccak-hash but because the API is actually inconvenient for our usecase and a utility function that hashes a single slice can easily be added locally.
See #12.
Yeah just to keep things organized really. Wanted to reduce the lines of code in a single module. |
No description provided.