Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: integrate offroad alerts and update notifications to ui report #33408

Merged
merged 1 commit into from
Sep 1, 2024
Merged

ci: integrate offroad alerts and update notifications to ui report #33408

merged 1 commit into from
Sep 1, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Aug 30, 2024 •
edited
Loading

Changes

  1. integrate offroad alerts and update notifications:

alerts

Screenshot from 2024-08-30 14-58-07

update available:

Screenshot from 2024-08-30 14-58-24

  1. Remove the meaningless WiFi Manager screenshot:

settings_network

  1. categorize the UI Screenshots, make it more clear.
  2. use the fcam instead of the ecam for capturing on-road alert screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

UI Screenshots

@deanlee deanlee marked this pull request as draft August 30, 2024 07:22
@deanlee deanlee mentioned this pull request Aug 30, 2024
Open
@deanlee deanlee marked this pull request as ready for review August 30, 2024 07:32
@deanlee deanlee marked this pull request as draft August 31, 2024 04:03
@deanlee deanlee force-pushed the ui_report_offroad_alerts branch 2 times, most recently from 34368cb to 3b2a1fd Compare August 31, 2024 04:55
@deanlee deanlee marked this pull request as ready for review August 31, 2024 04:57
@deanlee deanlee force-pushed the ui_report_offroad_alerts branch 2 times, most recently from 8873a24 to 3883c80 Compare September 1, 2024 03:54
@adeebshihadeh adeebshihadeh merged commit db9263d into commaai:master Sep 1, 2024
18 checks passed
@deanlee deanlee deleted the ui_report_offroad_alerts branch September 1, 2024 17:05
fredyshox pushed a commit that referenced this pull request Sep 4, 2024
@deanlee
ci: integrate offroad alerts and update notifications to ui report (#…
e318ca0 
…33408)

add offroad alerts
old-commit-hash: db9263d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh