Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve option typings when adding arguments to Command #49

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Preserve option typings when adding arguments to Command #49

merged 1 commit into from
Oct 15, 2023

Conversation

shadowspawn
Copy link
Contributor

Pull Request

Problem

Adding an argument to a command after adding an option was forgetting the option typings.

Solution

Add Opts to template return type.

ChangeLog

  • fix: preserve option typings when adding arguments to Command

@shadowspawn shadowspawn mentioned this pull request Oct 14, 2023
Merged
@shadowspawn shadowspawn merged commit a6f71e5 into develop Oct 15, 2023
24 checks passed
@shadowspawn shadowspawn deleted the feature/fix-argument-forgetting-options branch October 15, 2023 00:37
This was referenced Jul 17, 2024
Open
Open
This was referenced Sep 11, 2024
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo