Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RuntimeConfigProvider and switch to config.js #38

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Remove RuntimeConfigProvider and switch to config.js #38

merged 6 commits into from
Mar 21, 2023

Conversation

gciotola
Copy link
Contributor

@gciotola gciotola commented Mar 21, 2023 •
edited
Loading

What does this PR do?

Application config can now be read directly from global window instead of fetching a local json file.
Configuration is stored in window.clAppConfig and can be overwritten with a local configuration by creating a new file config.local.js inside the /public folder

In this way, RuntimeConfigProvider can be removed.

@gciotola gciotola marked this pull request as draft March 21, 2023 09:48
@gciotola gciotola added the enhancement New feature or request label Mar 21, 2023
@gciotola gciotola requested a review from malessani March 21, 2023 11:38
@gciotola gciotola marked this pull request as ready for review March 21, 2023 11:38
malessani
malessani approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@malessani malessani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gciotola gciotola merged commit 20380a1 into master Mar 21, 2023
@gciotola gciotola deleted the replace-config-json branch March 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malessani malessani malessani approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gciotola @malessani