Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external price logic coming from metadata #53

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove external price logic coming from metadata #53

merged 1 commit into from
Nov 16, 2023

Conversation

gciotola
Copy link
Contributor

What I did

This PR removes the recently added logic where line_items update was forced with _external_price if condition was met from line_item.metadata.

Now Core API stores the _external_price attribute, so when updating quantity it already knows if line_item use an external price

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@gciotola gciotola added the enhancement New feature or request label Nov 16, 2023
@gciotola gciotola requested a review from malessani November 16, 2023 14:32
@gciotola gciotola merged commit 3308efd into master Nov 16, 2023
2 checks passed
@gciotola gciotola deleted the fix/remove-external-prices-metadata branch April 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malessani malessani malessani approved these changes

Assignees

@gciotola gciotola

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gciotola @malessani