Update info for Windows users #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malessani
requested changes
Sep 11, 2023
Co-authored-by: Matteo Alessani <97170183+malessani@users.noreply.github.com>
Co-authored-by: Matteo Alessani <97170183+malessani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've update scripts in root
package.jsonto be executed recursively (-ror--rescursive) instead of using--filterthat does not work in Windows (see pnpm/pnpm#4562).However this should be the proper way to lunch scripts from the root, since
--filteris mostly used to restrict commands to a subset of packages.I've also added few line of docs in the
README.mdto help Windows users to run the project locally.How to test
Checklist