Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expires returnUrl param after a successful login #17

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

pfferrari
Copy link
Contributor

What I did

I updated the redirect method launched after a successful customer login to send a new additional expires GET param to the returnUrl. The expires param will contain the ISO date generated from the token expires Date returned by the js-auth library.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari changed the title Add expires redirect param after a successful login Add expires returnUrl param after a successful login Sep 12, 2023
Copy link
Member

@acasazza acasazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@pfferrari pfferrari merged commit 5e250f1 into main Sep 18, 2023
@pfferrari pfferrari added the enhancement New feature or request label Sep 18, 2023
@pfferrari pfferrari deleted the feat/add-expires-return-param branch January 2, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants