feat(sync/customers): add setStores
#1468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 126 126
Lines 3272 3272
Branches 751 751
=======================================
Hits 3217 3217
Misses 51 51
Partials 4 4
Continue to review full report at Codecov.
|
| expect(actual).toEqual([ | ||
| { | ||
| action: 'setStores', | ||
| stores: ['canada', 'usa'], |
There was a problem hiding this comment.
Are you really sure this works against our api? according to our docs (https://docs.commercetools.com/http-api-projects-customers#set-stores-beta) you have to provide a ResourceIdentifier (https://docs.commercetools.com/http-api-types.html#resourceidentifier) and not just a string...
There was a problem hiding this comment.
Good catch!
I was working under the MC context the whole time, which we always use string for.
adnasa
force-pushed
the
adnasa-update-customers-with-setStores
branch
from
7b3e351
to
2403522
Compare
|
Looks very good to me 👍 |
|
the lint passed. Do I need to wait for the other checks too? it doesn't look like they are running |
|
@adnasa Which other checks do you mean? |
|
oh well never mind... here we go 🎉 |
Summary
setStores. ref https://docs.commercetools.com/http-api-projects-customers#set-stores-betaThis is to prepare for a feature in the MC