Fix DropdownMenu component issues
#2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9dbc6c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| </Section> | ||
| )) | ||
| .add('DropdownMenu - List menu content', () => { | ||
| const optionsCount = number('Options count', 5); |
There was a problem hiding this comment.
This is to allow having long lists in the dropdown menu so the height and scrollability can be tested.
| @@ -40,6 +47,48 @@ export type TDropdownMenuProps = { | |||
| children: ReactNode; | |||
| }; | |||
|
|
|||
| function getScrollableParent(element: HTMLElement | null): HTMLElement | null { | |||
There was a problem hiding this comment.
We want to block the scroll of the nearest ancestor with scrolling enabled, if any.
| return getScrollableParent(element.parentElement); | ||
| } | ||
|
|
||
| function useScrollBlock(isOpen: boolean, triggerRef: RefObject<HTMLElement>) { |
There was a problem hiding this comment.
Just to extract a bit of logic from the component itself.
ddouglasz
approved these changes
May 2, 2024
| </Section> | ||
| )) | ||
| .add('DropdownMenu - List menu content', () => { | ||
| const optionsCount = number('Options count', 5); |
chloe0592
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
DropdownMenucomponent issues related to floating menu size and scrolling.Closes #2786
Description
This PR tries to fix two problems:
This is how we tackle those issues:
bodyscroll, but this component might be rendered in a scrollable container, so now we look for its first scrollable ancestor to block it while the dropdown is opened. It can be the case of multiple scroll containers in the page which might lead to potential issues, but we want to have a quick fix released for the majority of the use cases.menuMaxHeight) which consumers can use to limit the height of the floating menu however they want.Something that we intentionally left out of the scope of this PR is how to deal with dropdown menus opening the floating menu always downwards, which is not convenient when the triggering element is at the bottom of the page.
We will work on that as a follow up so we can release these fixes to make the component usable.