FCT 1207-1224: unique id's for error and warning containers in all -Field components
#2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: cdf8c77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tdeekens
approved these changes
Oct 9, 2024
packages/components/fields/async-select-field/src/async-select-field.spec.js
Show resolved
Hide resolved
tdeekens
reviewed
Oct 9, 2024
ByronDWall
force-pushed
the
FCT-1207-1224-unique-error-ids
branch
from
e70c1c4
to
d7c853d
Compare
ByronDWall
force-pushed
the
FCT-1207-1224-unique-error-ids
branch
from
d7c853d
to
9e5d8e6
Compare
tylermorrisford
approved these changes
Oct 9, 2024
tdeekens
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
This nicely fixes the broken setup we have. I liked @misama-ct suggestion around using :invalid. Maybe an investigation can be a followup if we can use it.
…r the passed id on the wrapper container isntead of on the container for each message so that all errors/warnings can be referred to by aria-errormessage using a single id, update all -Field components to build the id's for their error and warning containers based on their unique id, update tests
ByronDWall
force-pushed
the
FCT-1207-1224-unique-error-ids
branch
from
9e5d8e6
to
cdf8c77
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Guarantees unique HTML ID's in
FieldErrorsandFieldWarningscomponents. Guarantee unique ID's for error/warning field containers for each-Fieldcomponent. Is the fix for this bug reported in slack.Description
The
FieldErrorsandFieldWarningscomponents are meant to display error and warning fields. If multiple errors/warnings are passed to the component in the errors/warnings object, the component is meant to display multiple fields. Previously, if props.id was passed to the component, it would be used as the id attribute for each fields. If multiple errors/warnings were passed, each field would have the same id.This PR updates the
FieldErrorsandFieldWarningscomponent so that all fields have a parent wrapper on which theidis set. This insures that theidpassed to the component is always unique and refers to all errors/warnings.Each
-Fieldcomponent is updated so that it builds theidfor theerrorsandwarningscontainers based on the uniqueidused for the-Fieldinput. This insures that theidspecified in thearia-errormessageattribute for each-Fieldis unique. Tests added to each-Fieldcomponent to ensure the id generation works as expected.There are a lot of components changed, but changes for all
-Fieldcomponents are very similar and so should be fairly straightforward to review.