With packages in subdirs, compiler warnings leave subdirectory off file names

[chreekat]

I have a package in the subdirectory 'original/'. A compiler warning mentions a file in that package, Mechanism.hs. However, it's listed as "src/Mechanism.hs", not "original/src/Mechanism.hs":

b@fuzzbomb $ stack test --pedantic
Snowdrift-0.1.4: build
Preprocessing library Snowdrift-0.1.4...
[ 61 of 110] Compiling Mechanism        ( src/Mechanism.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.4.0/build/Mechanism.o )

src/Mechanism.hs:113:1: Warning:
    Top-level binding with no type signature:
      potentialPledge :: forall (m :: * -> *).
                         (MonadResource m, MonadBaseControl IO m, MonadLogger m) =>
                         Key Fixme.User
                         -> ProjectId
                         -> Control.Monad.Trans.Reader.ReaderT
                              SqlBackend m (Maybe (Entity Pledge), [Int64], [Int64])
<snip>...

b@fuzzbomb $ find . -name 'Mechanism.hs'
./original/src/Mechanism.hs

[borsboom]

I've reproduced. It looks to me like this code tries to canonicalize the path from the current directory rather than from the package's root directory. So if you do cd original; stack test --pedantic it will show the fully qualified path as expected.

[borsboom]

Should now be fixed in master.

[chreekat]

Thanks for quick action! Unfortunately I still have the problem. Or, a similar problem.

$ stack test --pedantic --no-run-tests
Snowdrift-0.1.4: build
Preprocessing library Snowdrift-0.1.4...
[ 61 of 110] Compiling Mechanism        ( src/Mechanism.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.4.0/build/Mechanism.o )

src/Mechanism.hs:113:1: Warning:
    Top-level binding with no type signature:
      potentialPledge :: forall (m :: * -> *).
                         (MonadResource m, MonadBaseControl IO m, MonadLogger m) =>
                         Key Fixme.User
                         -> ProjectId
                         -> Control.Monad.Trans.Reader.ReaderT
                              SqlBackend m (Maybe (Entity Pledge), [Int64], [Int64])

<no location info>:
Failing due to -Werror.
Progress: 1/2
--  While building package Snowdrift-0.1.4 using:
      /home/b/.stack/setup-exe-cache/setup-Simple-Cabal-1.22.4.0-x86_64-linux-ghc-7.10.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-1.22.4.0/ build lib:Snowdrift exe:Snowdrift exe:SnowdriftEmailDaemon exe:SnowdriftProcessPayments exe:sdm exe:sendmail-mock --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
$ stack --version
Version 0.1.7.0, Git revision eba1f2bd4ac0deb1bf946d7fb8113536963a20f9 (dirty) (2463 commits) x86_64
$

[borsboom]

Hm, strange. I actually tested the fix with the Snowdrift repo.

[chreekat]

Let me double-triple-confirm, because I appear to be getting different
output sometimes.

On Sat, Oct 31, 2015 at 5:00 PM, Emanuel Borsboom notifications@github.com
wrote:

Hm, strange. I actually tested the fix with the Snowdrift repo.

—
Reply to this email directly or view it on GitHub
#1259 (comment)
.

[chreekat]

Oops, can't do it now. I'll check it tomorrow.

[borsboom]

Ok, there was a second issue: it wasn't canonicalizing paths for warnings, only those for errors. That's now fixed on master as well.

[chreekat]

Ah, that was my hunch. Great!
On Nov 1, 2015 4:06 AM, "Emanuel Borsboom" notifications@github.com wrote:

Ok, there was a second issue: it wasn't canonicalizing paths for warnings,
only those for errors. That's now fixed on master as well.

—
Reply to this email directly or view it on GitHub
#1259 (comment)
.