Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less frequent test builds WAS stack test does not rebuild #319

Closed
gregwebs opened this issue Jun 15, 2015 · 14 comments
Closed

Less frequent test builds WAS stack test does not rebuild #319

gregwebs opened this issue Jun 15, 2015 · 14 comments
Milestone
P1: Must

Comments

@gregwebs
Copy link
Contributor

There seems to be major issues with stack test not re-building right now. It does not rebuild the test section when I make a change. An extreme example of this behavior is that I had a compilation failure in my tests and then when I run stack test a second time I see Test suite executable not found for ...
@gregwebs
Copy link
Contributor Author 

Version 0.0.2, Git revision 115972b9a2946b247482035be71fe269081a5640

@gregwebs gregwebs added this to the First stable release (0.1.0.0?) milestone Jun 15, 2015
@snoyberg
Copy link
Contributor

Ugh, I know what the problem is, hold on.

snoyberg added a commit that referenced this issue Jun 15, 2015
@snoyberg
Temporary workaround for #319
7b3bc28
@snoyberg
Copy link
Contributor

I temporarily disabled some dirtiness checking code in the test and bench building, and am forcing a rebuild each time. Can you try out master now to confirm that I was right about where the problem came from?

@snoyberg snoyberg self-assigned this Jun 15, 2015
@gregwebs
Copy link
Contributor Author

yes, that seems to work now

@snoyberg
Copy link
Contributor

Alright, determined the original problem: Stack.Package doesn't list test suite and benchmark files for dirtiness checking. @chrisdone and I are discussing how best to determine that information.

@snoyberg
Copy link
Contributor

For some reason I'm getting stuck figuring out the right way to do this without forcing a runghc Setup.hs build each time. I'm going to defer to a later milestone as an optimization.

@snoyberg snoyberg changed the title stack test does not rebuild Less frequent test builds WAS stack test does not rebuild Jun 16, 2015
@snoyberg snoyberg modified the milestones: Later improvements, First stable release (0.1.0.0?) Jun 16, 2015
@snoyberg snoyberg removed their assignment Jun 16, 2015
@snoyberg snoyberg modified the milestones: Later improvements, 0.2.0.0 Jun 16, 2015
@spinda
Copy link

spinda commented Jun 20, 2015

I noticed that stack test doesn't rebuild the test runner if its source has changed from when it was first built. The only way that I can find to rebuild the test runner is stack clean && stack test. Is this the same issue or a different one?

@gregwebs
Copy link
Contributor Author

what version of stack are you using?

@spinda
Copy link

spinda commented Jun 20, 2015

Ah, I forgot I was still on stack-0.0.2.1. Switching to the latest stack fixed my problem.

@snoyberg snoyberg mentioned this issue Jun 30, 2015
Closed
snoyberg added a commit that referenced this issue Jun 30, 2015
@snoyberg
Looks like #319 solved itself?
eba7164
@snoyberg
Copy link
Contributor

I've just pushed a commit that should make it so that tests are only rebuilt when necessary. I think the problems we were seeing previously with this code have been resolved, but I'd appreciate some testing by others to confirm. @gregwebs can you test out master?

@spinda
Copy link

spinda commented Jun 30, 2015

I'm still seeing stack test do a full rebuild immediately after completing a stack build.

@snoyberg
Copy link
Contributor

@spinda Can you clarify what you mean by full rebuild, or rather, what exact steps you're running? And are you using the latest master?

@snoyberg
Copy link
Contributor

snoyberg commented Jul 2, 2015

I think the original issue is resolved. If there are problems, please report in a new issue to avoid confusion.

@snoyberg snoyberg closed this as completed Jul 2, 2015
@snoyberg snoyberg removed the ready label Jul 2, 2015
@gregwebs
Copy link
Contributor Author

gregwebs commented Jul 6, 2015

Things seem to be working pretty smoothly now with switching between stack build and stack test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
P1: Must
Development

No branches or pull requests
3 participants
@gregwebs @snoyberg @spinda