Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode normalization on OS X can break package name parsing #3616

Open
snoyberg opened this issue Nov 30, 2017 · 2 comments
Open

Unicode normalization on OS X can break package name parsing #3616

snoyberg opened this issue Nov 30, 2017 · 2 comments
Labels
resolution: upstream issue

Comments

@snoyberg
Copy link
Contributor

See #3615 (comment) and #1810. I'm going to add a commit on a branch shortly that demonstrates this bug more fully. CC @borsboom @Blaisorblade.
snoyberg added a commit that referenced this issue Nov 30, 2017
@snoyberg
Redisable test on OS X due to Unicode normalization
2703ba4 
See #3616
snoyberg added a commit that referenced this issue Nov 30, 2017
@snoyberg
Demonstrate bug in #3616
0667eaf 
This newly added integration test demonstrates the bug described in #3616,
even using Stack 1.5.1. This demonstrates that PR #3615 does not
introduce a regression, and sets a bar for properly fixing this problem.
@snoyberg
Copy link
Contributor Author

It looks like our problems here may go deeper than Stack.

$ stack --resolver ghc-8.2.2 exec --no-ghc-package-path -- runghc Setup.hs configure --user
Configuring ば日本-4本-0.1.0.0...
$ stack --resolver ghc-8.2.2 exec --no-ghc-package-path -- runghc Setup.hs build
Saved package config file header is corrupt. Re-run the 'configure' command.

@snoyberg snoyberg mentioned this issue Nov 30, 2017
Open
@Blaisorblade
Copy link
Collaborator

Ah, we’re back to where it all started in #1337 :-)
Maybe we can have an issue (this one?) for the whole feature of Unicode package names, since it was never added and has external dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution: upstream issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgsloan @snoyberg @Blaisorblade