Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1810: Unicode-normalized pkg name comparison #2397

Merged
merged 4 commits into from
Aug 2, 2016
Merged

Fix #1810: Unicode-normalized pkg name comparison #2397

merged 4 commits into from
Aug 2, 2016
+8 −6

Commits on Aug 2, 2016

  1. Add dependency

    @Blaisorblade
    Blaisorblade committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    d784870 View commit details
    Browse the repository at this point in the history

  2. Normalize to NFC before comparison (fix commercialhaskell#1810) 

    The filename gets normalized to NFD on OS X causing spurious failures.

Let's normalize both sides to NFC in case the Cabal file is in some
other normalization for any reason.

This is a slight hack.
    @Blaisorblade
    Blaisorblade committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    7ec9dd8 View commit details
    Browse the repository at this point in the history

  3. Revert "integration-tests: disable failing unicode package name on OS… 

    … X, for now (commercialhaskell#1810)"

This reverts commit 87fec57, now that
we have a proper fix.
    @Blaisorblade
    Blaisorblade committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    12f9d01 View commit details
    Browse the repository at this point in the history

  4. Address review comments

    @Blaisorblade
    Blaisorblade committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    ccb120e View commit details
    Browse the repository at this point in the history