-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script command #2805 #2992
Merged
Merged
Script command #2805 #2992
Commits on Feb 16, 2017
-
This adds a basic script command. Most of the work involved has to do with preventing config files from being loaded. Originally we planned on creating an alternative set of config types for with and without a local config. That turned out to be prohibitively invasive. Instead, we now just create a dummy config file instead ~/.stack/script/lts-x.y (or /nightly-...). While this addresses reproducibility, it doesn't help with the speed concerns: script is now about 100ms faster than runghc on my system for the case where --package is provided, but it's still over a second for Hello World. The slowdown is inherent right now in checking if the relevant packages are installed. It would be nice to figure out a way to optimize the package check. Also, this should include some integration tests. It should be a simple matter of a test that includes a bogus stack.yaml and proving that stack script ignores it.
Configuration menu - View commit details
-
Copy full SHA for 4984a5a - Browse repository at this point
Copy the full SHA 4984a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed3250 - Browse repository at this point
Copy the full SHA 8ed3250View commit details -
Remove the NoLocal config type split
This was originally done to help implementation of #2805, but we ended up going a different route.
Configuration menu - View commit details
-
Copy full SHA for 32143ad - Browse repository at this point
Copy the full SHA 32143adView commit details -
Configuration menu - View commit details
-
Copy full SHA for df44688 - Browse repository at this point
Copy the full SHA df44688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29df0c4 - Browse repository at this point
Copy the full SHA 29df0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 462fbfe - Browse repository at this point
Copy the full SHA 462fbfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e53fd - Browse repository at this point
Copy the full SHA a8e53fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 011e4da - Browse repository at this point
Copy the full SHA 011e4daView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.