Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log GHC configure output on stack -v setup #3740

Merged
merged 7 commits into from
Jan 7, 2018
Merged

Log GHC configure output on stack -v setup #3740

merged 7 commits into from
Jan 7, 2018

Commits on Jan 5, 2018

  1. Log GHC configure output on stack -v setup 

    If -v global flag is passed to stack-setup subcommand we log the GHC
configure output.
Ref: commercialhaskell#3716
    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    fcf1435 View commit details
    Browse the repository at this point in the history

  2. Fix shadowing warning and indentation

    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    3b7f5dd View commit details
    Browse the repository at this point in the history

  3. Extract logLevel from env

    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    d91b1a0 View commit details
    Browse the repository at this point in the history

  4. Avoid explicit case analysis of logLevel

    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    8421402 View commit details
    Browse the repository at this point in the history

  5. Use withProcess_ since process output is logged anyway 

    Also fix function name (typo) referred in comments.
    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    724c444 View commit details
    Browse the repository at this point in the history

  6. Add back splitting stdout into lines

    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    fba0b2c View commit details
    Browse the repository at this point in the history

  7. Leave stdin open in withProc, sinkProcessStderrStdout 

    This allows us to reuse sinkProcessStderrStdout to print verbose output
while configuring GHC.
    Krishnan Parthasarathi committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    bf84086 View commit details
    Browse the repository at this point in the history