Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle internal libraries in GHCi. #3982

Merged
merged 9 commits into from
May 17, 2018
Merged

Handle internal libraries in GHCi. #3982

merged 9 commits into from
May 17, 2018

Commits on May 12, 2018

  1. Export utility functions for internal libraries 

    These should have been part of #3955 to be honest but were not needed at
the time. Now they are needed, so I'm adding them as a separate commit,
to be easy to cherry-pick them if the rest of the PR is not getting
merged.
    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    3e21e04 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete comment. 

    In #3955, as support for compiling with sublibraries was added, a stale
comment was left out in the code. Removed here as a separate commit to
be easy to cherry-pick if needed.
    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    15137cd View commit details
    Browse the repository at this point in the history

  3. Don't ignore sublibs and foreign libraries in Ghci.hs

    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    bc44551 View commit details
    Browse the repository at this point in the history

  4. Generate package description containing sublib info too

    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    89f5485 View commit details
    Browse the repository at this point in the history

  5. Handle internal libraries when building package description for GHCi. 

    When GHCi starts it looks for a package in the format given by Cabal but
stack used to pass the package name as the name of the sublibrary. So we
remove the sublibrary from the list of packages GHCi should search for
and add the munged name to the same list by using the `omitPkgs` and
`addPkgs` lists.
    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    3f63b5c View commit details
    Browse the repository at this point in the history

  6. Add field in pkg description for internal libs and use in GHCi. 

    We need to make a distinction between internal libraries and foreign
libraries since we want GHCi to reload when an internal library file
changes but we don't want it to confuse an internal library with a
foreign one.
    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    c972c89 View commit details
    Browse the repository at this point in the history

  7. Update ChangeLog

    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    7e0eba7 View commit details
    Browse the repository at this point in the history

  8. Hlint style fixes

    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    e8d40c2 View commit details
    Browse the repository at this point in the history

  9. Add integration test including reloading and starting from clean

    @mihaimaruseac
    mihaimaruseac committed May 12, 2018
    Configuration menu
    Copy the full SHA
    2936af5 View commit details
    Browse the repository at this point in the history