-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test to showcase failure with detailed-0.9 test type #4498
Integration test to showcase failure with detailed-0.9 test type #4498
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested, but it looks ok.
@NorfairKing Wasn't it the idea to have this test as a part of PR including 75e1091 ? |
@qrilka Yes, we should add that commit on top of this one, not below. |
I just added the fix on top. Now CI should pass. |
I'm not sure how to fix the CI failure. It seems time-based. |
@NorfairKing Seems to be a hlint issue: https://dev.azure.com/commercialhaskell/stack/_build/results?buildId=280 You need to remove the braces to fix it. |
That was fixed in a87c9bd |
Make sure to squash the appropriate commits. |
You will have to do the squashing yourself, @NorfairKing. We can only either merge/rebase as it is or squash all commits. But if you want to squash only a subset of them you'll have to do it yourself. |
776949b
to
ddd099d
Compare
@mihaimaruseac squashed |
Please also shortly describe how you tested your change. Bonus points for added tests!
This is a test.
See #4453