Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test to showcase failure with detailed-0.9 test type #4498

Conversation

NorfairKing
Copy link
Contributor

Please also shortly describe how you tested your change. Bonus points for added tests!

This is a test.

See #4453

@qrilka
Copy link
Contributor

qrilka commented Jan 9, 2019

LGTM

Copy link
Contributor

@dbaynard dbaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but it looks ok.

test/integration/tests/4453-detailed/Main.hs Outdated Show resolved Hide resolved
test/integration/tests/4453-detailed/files/LICENSE Outdated Show resolved Hide resolved
@qrilka
Copy link
Contributor

qrilka commented Jan 9, 2019

@NorfairKing Wasn't it the idea to have this test as a part of PR including 75e1091 ?

@NorfairKing
Copy link
Contributor Author

@qrilka Yes, we should add that commit on top of this one, not below.

@NorfairKing
Copy link
Contributor Author

I just added the fix on top. Now CI should pass.

@mihaimaruseac mihaimaruseac changed the title Integration test for the bug from issue 4453 Integration test to showcase failure with detailed-0.9 test type Jan 22, 2019
@NorfairKing
Copy link
Contributor Author

I'm not sure how to fix the CI failure. It seems time-based.

@psibi
Copy link
Member

psibi commented Jan 23, 2019

@NorfairKing Seems to be a hlint issue: https://dev.azure.com/commercialhaskell/stack/_build/results?buildId=280

You need to remove the braces to fix it.

@qrilka
Copy link
Contributor

qrilka commented Jan 23, 2019

That was fixed in a87c9bd
Just remerge with master @NorfairKing - you need to resolve the conflict with it anyway

@NorfairKing
Copy link
Contributor Author

Make sure to squash the appropriate commits.

@mihaimaruseac
Copy link
Contributor

You will have to do the squashing yourself, @NorfairKing. We can only either merge/rebase as it is or squash all commits. But if you want to squash only a subset of them you'll have to do it yourself.

@NorfairKing NorfairKing force-pushed the detailed-test-bug-regression-test branch from 776949b to ddd099d Compare January 28, 2019 08:26
@NorfairKing
Copy link
Contributor Author

@mihaimaruseac squashed

@mihaimaruseac mihaimaruseac merged commit 7b02e29 into commercialhaskell:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants