Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show resolver being used when
stack ghci
is invoked outside of a project directory #4521Show resolver being used when
stack ghci
is invoked outside of a project directory #4521Changes from 4 commits
1010696
3ff4da8
f2ebbcd
2f15af6
0b557b9
8d7aa01
fdd65b0
b044915
98d7c01
f845906
3dfd3b1
18bf364
a846424
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if there is no currently known way for this to be
Nothing
, there could possibly be a way now or in the future, and the error thrown byfromJust
is pretty frustratingly vague.How about instead, for the
Nothing
case, using something likeerror "Invariant violated: no project"
. One nice thing about usingerror
is that it will show where in stack's code the error occurred.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, ignoring the
Nothing
case is pretty ugly. I was thinking about this some more and decided to try something else: simply not print the resolver version if the project isNothing
. Would this work? I can do theerror
instead, but it's basically the same thing I had before, except it has a more useful error message.