-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globals (GHC boot packages) pruning #4547
Conversation
I have fixed integration test |
This package pruning implementation partially relies on information in |
I have changed the code quite a lot, also it looks like the refactoring I promised almost a month ago #4480 (comment) could be quite helpful in improving code around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments.
Use more correct pruning done in commercialhaskell/stack/pull/4547
Please include the following checklist in your PR:
Tested manually, plan to run integration tests.
Failure to build global packages as targets results in 2 errors (using
stack.yaml
from #4510 withtime
overriden):or
Fixes #4510
Also I plan to update curator to take these details into account (probably as a separate PR)