Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow local installs of mutable snapshot packages #4588

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Feb 14, 2019

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Tested manually.
Fixes #4578

With https://github.com/commercialhaskell/stack/blob/master/doc/build-overview.md being implemented we now have local installs of snapshot packages getting marked as mutable, i.e. having mutable (local) dependencies. This change removes reinstallation of those packages from snapshots.

@qrilka qrilka requested a review from snoyberg February 14, 2019 07:13
@qrilka
Copy link
Contributor Author

qrilka commented Feb 14, 2019

@snoyberg I've added another fix in 99afabc - does it look OK to you?
Fixes #4566

@snoyberg
Copy link
Contributor

Yup 👍

@snoyberg snoyberg merged commit 2c17ce5 into master Feb 18, 2019
@snoyberg snoyberg deleted the no-rebuilds branch February 18, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants