Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script extra deps #4593

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Script extra deps #4593

merged 3 commits into from
Feb 19, 2019

Conversation

snoyberg
Copy link
Contributor

Builds on top of #4591, since otherwise we'd have significant merge conflicts.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

Previously, any relative paths in a script's --resolver flag would be
considered relative to the current working directory. It's more logical
and consistent to have it relative to the directory the script lives in.
This makes the change.

Possible argument: it's a bit weird to put the resolver root into the
GlobalOptsMonoid value. Overall it seems like the best option to me, but
I'm open to other approaches.
@snoyberg snoyberg merged commit a26fc96 into master Feb 19, 2019
@snoyberg snoyberg deleted the script-extra-deps branch February 19, 2019 13:56
@qrilka
Copy link
Contributor

qrilka commented Mar 29, 2019

@snoyberg looks like this PR has broken test relative-script-snapshots I get the following from that test:

       stderr:
       Running: /home/qrilka/ws/h/stack-master/.stack-work/install/x86_64-linux-tinfo6/custom-snapshot-for-building-stack-with-ghc-8.2.2-RcJFh0uLBqbP/8.2.2/bin/stack subdir/script.hs
       Assertion failed
       CallStack (from HasCallStack):
         assert, called at src/Stack/Script.hs:99:26 in stack-1.10.0-F7lLShWkN1REko63qsyy8q:Stack.Script
       Main.hs: Exited with exit code: ExitFailure 1

Should I file a separate issue about this?

@snoyberg
Copy link
Contributor Author

snoyberg commented Mar 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants