Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove names from snapshots #4597

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Remove names from snapshots #4597

merged 2 commits into from
Mar 4, 2019

Conversation

snoyberg
Copy link
Contributor

It doesn't seem to match our overall approach to other config files.
Instead of giving a user-friendly name, I've modified the one place that
was displaying the name to instead display the location of the snapshot.

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

It doesn't seem to match our overall approach to other config files.
Instead of giving a user-friendly name, I've modified the one place that
was displaying the name to instead display the location of the snapshot.
@snoyberg snoyberg requested a review from qrilka February 19, 2019 14:30
Copy link
Contributor

@qrilka qrilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what about fixing curator? (CI hinted about those)

@snoyberg
Copy link
Contributor Author

My mistake, thanks for pinging me.

@snoyberg snoyberg merged commit 83a60b1 into master Mar 4, 2019
@snoyberg snoyberg deleted the remove-snapshot-name branch March 4, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants