Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for not working compiler override in stack.yaml #4608

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fix for not working compiler override in stack.yaml #4608

merged 2 commits into from
Mar 6, 2019

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Mar 6, 2019

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Integration test succeeds

snoyberg and others added 2 commits March 6, 2019 12:37
@snoyberg
Integration test: compiler override does not work
59086c1 
Confirmed that this test passes with Stack 1.9.3 and fails with master.
@qrilka
Enable back compiler override in stack.yaml
ba50a70
@qrilka qrilka requested a review from snoyberg March 6, 2019 13:58
@qrilka qrilka changed the title Compiler override does not work Fix for not working compiler override in stack.yaml Mar 6, 2019
snoyberg
snoyberg approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing my mistake :)

@snoyberg snoyberg merged commit 8f785a2 into master Mar 6, 2019
@snoyberg snoyberg deleted the compiler-override-does-not-work branch March 6, 2019 14:57
@snoyberg snoyberg mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qrilka @snoyberg