Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize custom-setup deps for stack dist #5461

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Dec 21, 2020

Resolves #4006

This explicit-setup-deps unnecessary and thus it was removed

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Tested manually

@qrilka qrilka requested a review from snoyberg December 21, 2020 13:36
@qrilka
Copy link
Contributor Author

qrilka commented Dec 21, 2020

@snoyberg one thing which I'm not quite sure about is removing that option - this makes this PR not backwards compatible. Do we need to do some "deprecation" step before removing it?

This `explicit-setup-deps` unnecessary and thus it was removed
@qrilka qrilka force-pushed the 4006-setup-custom-setup-deps branch from 339b525 to 3464638 Compare December 21, 2020 13:41
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's OK to remove the option.

@qrilka qrilka merged commit 30224e3 into master Dec 22, 2020
@mpilgrem mpilgrem deleted the 4006-setup-custom-setup-deps branch October 16, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDist code deling with custom-setup incorrect
2 participants