Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with ignoring cpPkg and cpCompiler fields. #5597

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

Haskell-mouse
Copy link
Contributor

@Haskell-mouse Haskell-mouse commented Aug 2, 2021

It looks like a user can't override location ghc and ghc-pkg, because these options are ignored in ensureConfig.
I prefer to leave findExecutable checking and I've just removed obviously mistaken adding "--with-ghc/ghc-pkg=" to the path.

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Would you mind adding a ChangeLog entry for this bug fix?

@Haskell-mouse
Copy link
Contributor Author

Looks great, thanks! Would you mind adding a ChangeLog entry for this bug fix?

Thanks. I've added a short note to the Bug fixes section.

@snoyberg snoyberg merged commit 37cdf40 into commercialhaskell:master Aug 10, 2021
@snoyberg
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants