Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable hakyll-convert #7083

Merged

Conversation

Minoru
Copy link
Contributor

@Minoru Minoru commented Aug 8, 2023

0.3.0.4@rev:3 allows time < 1.13.

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh — Not applicable
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated) — time 1.13 is not supported because there are no compilers that bundle that version
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

./verify-package hakyll-convert-0.3.0.4@rev:3 passed.

0.3.0.4@rev:3 allows time < 1.13.
@Minoru
Copy link
Contributor Author

Minoru commented Aug 8, 2023

CI failure don't seem relevant to my changes.

@jkachmar jkachmar merged commit 8f6ca37 into commercialhaskell:master Aug 10, 2023
1 check failed
@Minoru Minoru deleted the feature/re-enable-hakyll-convert branch August 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants