Validate zero modules #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two private functions in 'internal/module_config': - func (cfg ModuleConfig) collectMissing() []string - func findMissing(reflect.Value, string, string, []string) These are unexported functions that aid in introspecting a datastructure to see if it has all its expected data. These functions are implicitly invoked via: - func LoadModuleConfig(string) (ModuleConfig, error) If there are errors then the program aborts with appropriate output.
davidcheung
reviewed
Dec 15, 2020
| func LoadModuleConfig(filePath string) (ModuleConfig, error) { | ||
| config := ModuleConfig{} | ||
|
|
||
| var required = []string{} | ||
| fmt.Printf("%+#v\n", required) |
There was a problem hiding this comment.
I assume this is not needed anymore? since we're treating non-omitempty as required
There was a problem hiding this comment.
Yeah, for sure! Thanks.
davidcheung
reviewed
Dec 15, 2020
| // If the value of the current node is equal to the zero value for its datatype | ||
| // and its struct field does *not* have a "omitempty" value, then we assume it | ||
| // is missing and add it to the resultset. | ||
| func findMissing(obj reflect.Value, path, metadata string, missing *[]string) { |
davidcheung
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two private functions in 'internal/module_config':
These are unexported functions that aid in introspecting a datastructure to see if it has all its expected data.
These functions are implicitly invoked via:
If there are errors then the program aborts with appropriate output.